Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Can mutate blocks in readOnly workspace #7622

Merged
merged 1 commit into from
Oct 31, 2023

Conversation

Apoorvgarg-creator
Copy link
Contributor

The basics

The details

Resolves

Fixes #7557

Proposed Changes

When the source block is not editable, the bubble won't be visible hence it won't allow mutation of the block.

Reason for Changes

It was a bug causing the user to mutate a block in read-only workspace.

Test Coverage

Documentation

Additional Information

@Apoorvgarg-creator Apoorvgarg-creator requested a review from a team as a code owner October 31, 2023 16:37
@github-actions github-actions bot added the PR: fix Fixes a bug label Oct 31, 2023
@BeksOmega BeksOmega assigned BeksOmega and unassigned maribethb Oct 31, 2023
@BeksOmega BeksOmega requested review from BeksOmega and removed request for maribethb October 31, 2023 18:12
Copy link
Collaborator

@BeksOmega BeksOmega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM =) Once I pull it down and manually test it I'll get this merged!

@BeksOmega BeksOmega merged commit 37bfcbc into google:develop Oct 31, 2023
12 checks passed
@Apoorvgarg-creator Apoorvgarg-creator deleted the patch-7557-fix branch November 1, 2023 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: fix Fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can mutate blocks in readOnly workspace
3 participants